Validate that resources belong to the right device. #4207
Merged
+109
−13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ErichDonGubler
approved these changes
Oct 4, 2023
cwfitzgerald
approved these changes
Oct 4, 2023
There was a problem hiding this comment.
In the future, I think it would be nice to have a trait like
trait DeviceChild {
fn get_device_id(&self) -> ....;
fn is_child_of(&self, device: Id<Device>) -> Result<(), DeviceError> {
....
}
}
or something to streamline this a bit and prevent mistakes, but for now this is fine.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
cargo clippy.Connections
Fixes #3927
Description
A pretty boring and mechanical change set although fairly important for the browser use case. Each entry point that takes resources as input must check that these resources are associated with the same device.
I'm sure that I have forgotten some, thankfully it looks like the CTS is rather thorough about testing this so we'll see what's missing when this makes its way into firefox.
Testing
I enabled the the
device_msimatchtest which I added when filing the issue. It only covers a tiny portion of the cases but the CTS has good coverage of this so adding exhaustive tests here is not as important.